Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: ESLint 9 #1478

Merged
merged 11 commits into from
Nov 21, 2024
Merged

chore!: ESLint 9 #1478

merged 11 commits into from
Nov 21, 2024

Conversation

tassoevan
Copy link
Collaborator

@tassoevan tassoevan commented Nov 5, 2024

Proposed changes (including videos or screenshots)

It upgrades ESLint to version 9, migrating all the configuration files to the flat config format. Additionally, the @rocket.chat/eslint-config-alt package is abandoned.

Issue(s)

Further comments

A staggering amount of files changed due to the non-sensical change of import/order rule from eslint-plugin-import. To ensure a minimally sane order, groups of imports had to be split.

Copy link

changeset-bot bot commented Nov 5, 2024

⚠️ No Changeset found

Latest commit: 631f198

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tassoevan tassoevan force-pushed the chore/eslint branch 7 times, most recently from 78a2d73 to d881b9e Compare November 8, 2024 19:57
@tassoevan tassoevan changed the title chore: ESLint 9 chore!: ESLint 9 Nov 21, 2024
@tassoevan tassoevan requested a review from a team November 21, 2024 14:36
@tassoevan tassoevan marked this pull request as ready for review November 21, 2024 14:38
@tassoevan tassoevan merged commit ce6bb5b into main Nov 21, 2024
9 checks passed
@tassoevan tassoevan deleted the chore/eslint branch November 21, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants